[cmake-developers] New command 'file(LOCK_DIRECTORY ...)'

Brad King brad.king at kitware.com
Mon Dec 1 15:32:40 EST 2014


On 12/01/2014 03:26 PM, Stephen Kelly wrote:
> Existing uses of strtol also check errno. I guess your implementation should 
> too. 

Yes, IIUC it is a range check on whether the value can be represented.

> Then the existing users should use this new method.

In that case the type should be changed to 'long' instead of 'int',
and the current call site should be updated accordingly.

Thanks,
-Brad



More information about the cmake-developers mailing list