[cmake-developers] Patch pull request: support for shader entry point and shader model for Visual Studio FXCompiler custom tool build

[Gilles Khouzam]

Hi Cedric

Thanks for the patch,

I had started adding a full set of shader property support on our fork: 

https://cmakems.codeplex.com/SourceControl/changeset/c5f9c207ee3490dda1e4c2a0eb647492b934fc11 

I haven't asked to get this pulled in because with the number of options, it is probably better to add this support as a flag set instead of having a set of specific if statements. I haven't had a chance to complete this work though.

-----Original Message-----
From: Brad King [mailto:brad.king at kitware.com] 
Sent: Monday, December 1, 2014 07:06
To: Cedric Perthuis
Cc: cmake-developers at cmake.org; Gilles Khouzam
Subject: Re: [cmake-developers] Patch pull request: support for shader entry point and shader model for Visual Studio FXCompiler custom tool build

On 11/29/2014 12:51 AM, Cedric Perthuis wrote:
> So, here's a patch to address this. 
[snip]
> +    if (const char* se = sf->GetProperty("VS_SHADER_ENTRY_POINT"))
[snip]
> +    if (const char* sm = sf->GetProperty("VS_SHADER_MODEL"))

Thanks.  Here are some comments on the patch:

* Please update the documentation too.  See

   Help/manual/cmake-properties.7.rst
   Help/prop_sf/VS_SHADER_TYPE.rst

  for how VS_SHADER_TYPE is documented.

* Please update the test.  See

   Tests/VSWinStorePhone/CMakeLists.txt

  for current testing of VS_SHADER_TYPE.

Thanks,
-Brad