[cmake-developers] [Review Request] Topic wxWidgets-cflags

[Richard Shaw]

On Thu, Aug 21, 2014 at 2:21 PM, Brad King <brad.king at kitware.com> wrote:

> On 08/21/2014 02:30 PM, Richard Shaw wrote:
> >    if   (wxWidgets_CXX_FLAGS)
> > +    # Flags are expected to be a string here, not a list.
> > +    string(REPLACE ";" " " wxWidgets_CXX_FLAGS "${wxWidgets_CXX_FLAGS}")
> >      set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS}")
>
> Thanks.  However, we shouldn't leak our local modification to the value
> of wxWidgets_CXX_FLAGS, so the substitution should be done with the
> result stored in a temporary local variable.
>
> Also, please start the commit message in "UsewxWidgets: ...".
>
> Ok, all updates have been incorporated, so I'm looking for an ACK to know
if it appears ready to push into "next".

http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=e6fa6e60f6330ddf60294a0d9a6ed4cb3f27d4c4

Thanks,
Richard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140822/7e25993c/attachment-0002.html>