[cmake-developers] Self Introduction and fixes to the FindwxWidgets module

[Brad King]

On 08/21/2014 09:09 AM, Richard Shaw wrote:
> I mean volunteered to take over maintenance of the FindwxWidgets

Welcome, and thanks for volunteering!

> bug 11296.
> 
> The problem is it doesn't take into account whether you're
> cross-compiling for path type detection. There is a solution
> that works provided in the bug which I intend to implement but
> I had some other observations:
> 1. The 2nd if statement seems superfluous. If the path type is
> not win32 then it must be unix, correct? While I *think* all
> the platforms are covered, the conditional logic still technically
> leaves the opportunity for both conditionals to be false and then
> it doesn't set the path type at all.

Yes, it should be one or the other.

> 2. The user has no manual override. I would think capability
> detection would be a much better approach than platform detection
> but I'm not sure how to implement it. For the meantime and to not
> make too disruptive of a change to the logic that's been out there
> for so long I think it would be good to
> provide a way for the user to override the path type.
> 
> Is there a preferred/good practices way to implement this?

You could check CMAKE_HOST_SYSTEM_NAME (better platform detection),
or just try to find and use wx-config and otherwise fall back
(capability detection).

Thanks,
-Brad