[cmake-developers] [PATCH] New module: FindIce.cmake

[Roger Leigh]

On Tue, Aug 12, 2014 at 09:08:57PM +0100, Roger Leigh wrote:
> On Mon, Aug 11, 2014 at 11:07:57AM -0400, Brad King wrote:
> > On 08/08/2014 08:56 AM, Roger Leigh wrote:
> > > On Thu, Aug 07, 2014 at 06:49:28PM +0100, Roger Leigh wrote:
> 
> > 3. There is a lot of hard-coded version-specific information
> >    that will require constant maintenance and new releases
> >    of CMake as the upstream versions change.  This is not
> >    maintainable, and is one reason the package configuration
> >    file approach linked above is much preferred to a Find
> >    module.  Are there Windows Registry entries available
> >    that specify the install location?
> 
> I have reworked this so that it loops through all the variants
> which are compatible with the generator in use, plus fallbacks.
> The disadvantage is that this now means that on Windows you
> won't get an outright failure if the visual studio version
> mismatches with the detected libraries whereas the previous
> approach hardcoded all that knowledge.  That said, it's a
> whole lot more flexible and maintainable this way and so is an
> acceptable tradeoff.
> 
> Regarding the Windows Registry, I've taken a look and it looks
> like there might be some usable keys from the installer which
> could be used, but I'll need to do further digging with all
> the different versions to see what's most usable here.

This turned out to be fairly simple at least for Ice versions
3.4.0 - 3.5.1, which all have the same naming convention.
Earlier versions have odd naming conventions and are in
Wow6432Node so I've not included them (they are obsolete in
any case, and ICE_HOME can be set to use them).

I've attached an updated copy which now includes using the
registry.  Happy to make any further improvements if needed.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-FindIce-New-module-to-find-ZeroC-Ice.patch
Type: text/x-diff
Size: 20675 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140812/3916a797/attachment-0002.patch>