[cmake-developers] [PATCH] Fix broken PGI builds for liblzma.

[Chuck Atkins]

>
> > +#if defined(__STDC_VERSION__) && (__STDC_VERSION__ > 199901L) && \
>
> Did you mean ">= 199901L" here rather than ">"?
>

I did, that was a typo.


On 08/01/2014 02:22 PM, Chuck Atkins wrote:
> > I noticed the recent merge of liblzma broke the PGI compiler.
>
> It is not surprising that there is lingering C99 code because
> the library implementation was ported from C99 to C89/90 for
> inclusion in CMake.
>

Not only that but the line in question was being protected from MSVC, not
C99.  Given that it was ported though, I'd say the better fix would be to
remove the C99 version entirely and always use the C89 version without the
static array dimensions.  See updated patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140804/c5ab5a42/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-broken-PGI-builds-for-liblzma.patch
Type: text/x-patch
Size: 2971 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140804/c5ab5a42/attachment.bin>