[cmake-developers] [PATCH] remove "x" placeholder from STREQUAL operands
Ben Boeckel
ben.boeckel at kitware.com
Fri Apr 18 12:49:10 EDT 2014
On Fri, Apr 18, 2014 at 10:06:36 -0400, Matthew Woehlke wrote:
> Where a variable is created (e.g. the SET command), presumably.
Internally-created variables would then be missed.
string(TOUPPER "mystr" "varname with spaces")
> I don't think the performance hit should be so bad if only writes are
> checked, should it?
Actually, I stuck a bloom filter in front of the definition map check to
get a decent performance improvement (10%-20% depending on the project)
on another branch. Using the loop which hashes to also check for valid
characters might be possible.
--Ben
More information about the cmake-developers
mailing list