[cmake-developers] Update to the P4 patch

Pedro Navarro pnavarro at netflix.com
Thu Oct 31 16:40:30 EDT 2013


Hi,

Attached is an updated version of the P4 patch.

Perforce always returns absolute file paths with the depot name
(//depot/path/to/file.txt) and that was breaking the test infrastructure,
which expects relative path names.

Previously I was removing the depot name (//depot/) to make the test happy
but I realized it was a bad idea now that we are looking at changelists
from CDash using P4Web, as the depot needs to be added manually (which will
break multi-depot repositories).

The new version does not strip the depot name from the files, which are
passed untouched to Update.xml (that should have been the right behavior
all along). CTestUpdateCommon removes a given prefix (if defined in the
REPOSITORY_FILE_PREFIX variable) after reading files from Update.xml to
satisfy the checks.

Pedro
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20131031/3ad14387/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Do-not-remove-the-depot-name.patch
Type: text/x-patch
Size: 2782 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20131031/3ad14387/attachment-0002.bin>


More information about the cmake-developers mailing list