[cmake-developers] Perforce Patch for CTest

Brad King brad.king at kitware.com
Thu Oct 24 08:59:03 EDT 2013


On 10/23/2013 08:43 PM, Pedro Navarro wrote:
> Thanks a lot! Glad we could contribute.
> 
> What's the process for changes? :) Adding support for P4Web
> in CDash made me realize that maybe we need to change how
> revisions are reported in Update.xml (file revisions instead
> of changelists), I'm looking into that right now.

Okay.  Please attach the next patch here as before.

Also, while fixing the CTest.UpdateP4 test to work without p4
in the PATH I noticed that the reason the test needs to set
CTEST_UPDATE_COMMAND/UpdateCommand instead of
CTEST_P4_COMMAND/P4Command is because the test is not set up
to trigger cmCTestUpdateHandler::DetectVCS's detection of
.p4 or .p4client in the source tree.  Therefore CTest cannot
tell from the source tree which VCS tool manages it.  I'm not
a regular Perforce user, but is it common to not have any .p4*
files in a checkout?  Should the test use them?

Thanks,
-Brad



More information about the cmake-developers mailing list