[cmake-developers] Perforce Patch for CTest

[Pedro Navarro]

Good point :) Here's the new patch. GetWorkingRevision returns "0" instead
of empty now, eliminating the need to do the check in NoteOldRevision and
NoteNewRevision

Pedro


On Tue, Oct 22, 2013 at 2:49 PM, Rolf Eike Beer <eike at sf-mail.de> wrote:

> Am Dienstag, 22. Oktober 2013, 14:36:36 schrieb Pedro Navarro:
> > Attached is the new patch with Eike's recommendations.
>
> One more nitpick ;)
>
> +  this->OldRevision = this->GetWorkingRevision();
> +  if(this->OldRevision.empty())
> +    {
> +    this->OldRevision = "0";
> +    }
>
> That code comes twice, for the only 2 callers of GetWorkingRevision(). I
> would
> say just modify that method to return "0" in that case.
>
> Eike
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20131022/9bd0fb8f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Perforce-support-for-CTest.patch
Type: text/x-patch
Size: 34692 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20131022/9bd0fb8f/attachment-0002.bin>