[cmake-developers] Perforce Patch for CTest

Pedro Navarro pnavarro at netflix.com
Tue Oct 22 15:44:42 EDT 2013


Oh, I see. Sure, I can see how that could become easily a hard to debug
problem.


On Tue, Oct 22, 2013 at 12:08 PM, Rolf Eike Beer <eike at sf-mail.de> wrote:

> Am Dienstag, 22. Oktober 2013, 11:51:52 schrieb Pedro Navarro:
> > > I would extend the regex in the DiffParser constructor to contain " -
> " at
> > > the
> > > end to make the propability that a filename with # in it would cause
> > > issues
> > > smaller. Also I find the usage of both Options and options in
> > > SetP4Options() an
> > > invitation for confusion (and possible errors).
> >
> > I'll change the regex. Although I verified it in debuggex to make sure we
> > could correctly handle different combination of files with # and other
> > characters in it, it makes sense to add the additional check.
> >
> > About the options, do you mean not using P4Options when doing an update
> if
> > options for the update commands are given? I have to admit that I don't
> > fully understand the difference between Update Options and VCS Specific
> > options (I got that code from the GIT implementation) but Perforce has
> the
> > notion of global and command specific flags. In this case, the global
> flags
> > are the P4Options which are used to specify how do you connect to the
> > server (host, port, username) and which client view to use, the "other"
> > options are the flags you pass for the update command, which are
> completely
> > different. I agree it can be confusing
>
> I meant that you have one variable called Options and one called options.
> This
> is just asking for trouble IMHO. Even more as both are of the same type.
>
> Eike
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20131022/57f55738/attachment.html>


More information about the cmake-developers mailing list