[cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

[Bill Hoffman]

On 10/18/2013 6:50 PM, Nils Gladitz wrote:
> Hello Bill,
>
> I've updated the topic with (I think) improved sorting.
> Tests are now prioritized by depth within the dependency graph and
> within each depth level they are further ordered by cost.
> This gives better total test time for my test case and preserves
> correctness in relation to RUN_SERIAL
Can you add a few comments into the code that describe what you are 
doing so it will be easier to follow?   Maybe a block comment that 
describes the high level approach?


Also, small change, I don't think we need this copy anymore:
  // copy the depend tests locally because when
   // a test is finished it will be removed from the depend list
   // and we don't want to be iterating a list while removing from it
   TestSet depends = this->Tests[test];
   size_t totalDepends = depends.size();

// This should work:
if(this->Tests[test].size() == 0)


It would also be good to merge your test case 
http://pastebin.com/3zXsTrem into its own test or one of these:

CTestTestParallel.

I am also getting a test failure here:

190: Test project C:/Users/hoffman/Work/My 
Builds/cmake-ninja/Tests/CTestTestStopTime
190:     Start 1: TestSleep
190: 1/2 Test #1: TestSleep ........................   Passed   29.99 sec
190:     Start 2: ShouldNotRun
190: 2/2 Test #2: ShouldNotRun .....................***Failed   30.00 sec
190:
190: 50% tests passed, 1 tests failed out of 2
190:
190: Total Test time (real) =  60.00 sec
190:
190: The following tests FAILED:
190:      2 - ShouldNotRun (Failed)
1/1 Test #190: CTestTestStopTime ................***Failed  Required 
regular expression not found.Regex=[The stop time has been passed
] 60.67 sec


Thanks.

-Bill