[cmake-developers] CheckStructHasMember does not support C++ only structs

Brad King brad.king at kitware.com
Wed Oct 2 10:23:03 EDT 2013


On 10/02/2013 07:14 AM, Daniele E. Domenichelli wrote:
> On 25/09/13 18:49, Brad King wrote:
>> On 09/25/2013 12:16 PM, Daniele E. Domenichelli wrote:
>>> I updated the CheckStructHasMember_CXX topic.
>>
>> That looks good, though I haven't tested it by hand myself.
>>
>> While at this, please look at adding test cases covering this
>> module, both the old and new signatures.
> 
> Done... I merged the topic to next in order to check that the tests work
> on all the build machines.
> Please have a look and let me know if the tests are good enough.

They look good to me.  We'll see how the dashboards do.

You could also add a RunCMake/CheckModules case to check the
error conditions (bad args and bad language).

Thanks,
-Brad



More information about the cmake-developers mailing list