[cmake-developers] Review Request: Topic ExternalProject-independent-step-targets

Daniele E. Domenichelli daniele.domenichelli at gmail.com
Fri Nov 22 15:00:33 EST 2013


On 22/11/13 19:03, Brad King wrote:
> On 11/22/2013 12:28 PM, David Cole wrote:
>> So I would add to the documentation saying that typically, only the 
>> download and update steps ought to be considered as "independent" step 
>> targets.
> 
> Would it make sense to only allow it for specific steps, or to disallow
> it for specific steps for which it is "known bad"?

I wouldn't allow it only for specific step, because user might want to
add some custom step and they could be either "dependent" or "independent".
For now I added some documentation and added an AUTHOR_WARNING if used
for the steps configure, build, install, or test.


>> Also, I would ask Brad if the "-# ::" line you've removed is important 
>> for the new documentation generation scheme... I would assume so, but I 
>> do not know enough about how it works yet.
> 
> Actually the topic should be rebased on master to resolve conflicts
> with the documentation formatting cleanup I made here:

I moved the "::" in the previous line, as Brad did ;)
Anyway I rebased the branch on master and solved the conflicts



Cheers,
 Daniele



More information about the cmake-developers mailing list