[cmake-developers] A few topic reviews for Stephen

[Brad King]

On 05/22/2013 06:12 PM, Stephen Kelly wrote:
> Brad King wrote:
>> I'm not sure what caused that failure, but according to local testing
>> on my VS 6 the failure we now see is caused by (according to git bisect)
>> the language-generator-expressions topic.  I've merged join-genex but
>> you'll have to look into the failure further.
> 
> Interesting. Nothing in that patch jumps out to me as the cause.

Okay, I'll try to dig further since I can reproduce it.

>> Meanwhile I've discovered we let a failure leak into master.  The
>> fix-include_directories-whitespace-handling topic:
>>
>> Does the file need to be empty of symbols for this test?
> 
> Nope, we can add some symbol to the file. What's the simplest thing we can 
> add?

In noticed that Watcom failed on Windows too, so we need a
dllexport-ed symbol:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a97240b9

-Brad