[cmake-developers] review request: fix-protobuf-threads
Brad King
brad.king at kitware.com
Tue May 21 15:54:16 EDT 2013
On 05/08/2013 05:09 PM, Matthew Woehlke wrote:
> After chatting with Marcus how to resolve ParaView link errors due to
> things using Google Protobuf needing to link to pthread, I have updated
> FindProtobuf.cmake to also find the pthread library on UNIX platforms
> and include it in PROTOBUF_LIBRARIES.
Cc-ing Philip, the current maintainer of the module.
> This should fix link errors in a number of projects and/or remove the
> need for downstream users to add pthread themselves when using protobuf.
>
> The branch (name in summary) is on stage. Please have a look if this is
> reasonable and can be merged to master once 2.8.11 is out.
The change looks okay to me. Please revise the commit message
to start in "FindProtobuf:" and update the text accordingly.
Then merge to 'next' for testing.
Thanks,
-Brad
More information about the cmake-developers
mailing list