[cmake-developers] Safe source list GLOBs

[Brad King]

On 05/11/2013 11:09 PM, Wojciech Knapik wrote:
> I recently ran into the issue of GLOBs being unsafe for source lists and
> wrote a very simple piece of code to fix the problem. A generalized
> version of that code is available here:
> 
> https://github.com/wknapik/scm/blob/master/code/cmake/Modules/RegenerateSourceListGlobs.cmake
> 
> It seems to work quite well, at least on Linux. If you guys think this
> is worth turning into an official module, I can make any changes
> deemed necessary. I'm not up for the maintainer role though.

It looks like you're using a custom target to re-run CMake with
dependencies on the source directories themselves.  I think this is
suitable as an example in a Wiki but not as an official module.

This would be much better done as a change to CMake's implementation.
We already generate a rule to re-run CMake when CMakeLists.txt and
other files read by CMake change.  One could add an option to add
directories to the dependencies of that rule too.  Look for the
AddCMakeDependFile method for example.  If you go this route please
post a proposed interface here first before diving into the effort
of a patch.

> PS. The wiki page mentioned in Modules/readme.txt says you should send
> stuff like this to cmake-developers, but the email referred in the first
> sentence says you should send new module proposals to the cmake list. I
> guess the wiki could use an update.

Which wiki page?  The module maintainer one is:

 http://www.cmake.org/Wiki/CMake:Module_Maintainers

and that one says cmake-developers.

Thanks,
-Brad