[cmake-developers] CMAKE_AUTOMOC, system include dirs and target include directories

[Alexander Neundorf]

On Tuesday 19 March 2013, Stephen Kelly wrote:
> Alexander Neundorf wrote:
> > The comment to your commit is not really correct.
> > 
> > "The commit d2536579 (Automoc: fix regression #13667, broken build in
> > phonon, 2012-11-19) changed Automoc to try to re-add the Qt header dir
> > if it was stripped out as an implicit include from the moc command
> > line."
> > 
> > This commit more or less doesn't matter, since the following commit
> 
> But it was part of the 2.8.10.2 release. The followup was not.

Oh, really ?
So long ago already...
 
> > acc22400 basically completey reverts it, i.e. it does not "go further",
> > but does something differently:
> > 
> > "The follow-up commit acc22400 (Automoc: get include dirs without
> > 
> >  stripping implicit include dirs off, 2012-12-07) went further by not
> >  removing the implicit include dirs, if they were specified specifically
> >  by the user."
> > 
> > Some patch before simply added all of the implicit include dirs for moc,
> > but moc cannot handle that, it errors out on some files then.
> 
> That may be, but it seems no such commit was merged to master. The breakage
> you are referring to is probably
> 
>  https://bugreports.qt-project.org/browse/QTBUG-28045

Yes.

> which was fixed before 5.0.0, so we could consider adding all implicit
> include dirs again.

Yes, we could.
But after seeing that breakage I don't have a good feeling about this.

I think your current patch is better.

Alex