[cmake-developers] please review: fix UseJava.cmake to support dependent jars

[Matthew Woehlke]

On 2013-03-14 11:14, Andreas Schneider wrote:
> On Thursday 14 March 2013 10:57:10 Brad King wrote:
>> On 03/14/2013 10:47 AM, Matthew Woehlke wrote:
>>> This is now pushed to stage/fix-java-jar-depends. If someone
>>> knowledgeable could have a look, that would be much appreciated.
>>
>> Andreas, Nicholas?
>
> Hi Brad,
>
> thanks for the mail. I've reviewed the patches and they look fine for me. I'm
> sorry that I don't have the time to test them right now.

Thanks.

So... I did some spelunking into the history of this module, and I am 
confused... is add_jar (referring to the current state in master) 
*supposed* to silently consume arguments that are jar files without 
doing anything with them? Because AFAICT that's what it has always done.

Specifically I'm thinking about if this is might be a behavior change 
that breaks things for existing users. (If that's a concern, maybe 
add_jar could use cmake_parse_arguments to accept an explicit list of 
jar files that should be used as dependencies/classpath?)

I'd like to also go ahead and get this into next (and if possible, 
2.8.11rc2 :-) ). Any objections?

-- 
Matthew