[cmake-developers] [FindQt4.cmake] possible typo causes Qt4 version check failure

[Brad King]

On 03/13/2013 04:37 AM, m.hergarden wrote:
> The following commit:
> 21123416b4c2d49fe981279b10fbc78c8d07c491
> 
> Introduced this line:
> Modules/FindQt4.cmake line 564:
> 
> set(${QMAKE_RESULT} "${QT_QMAKE_QMAKE_EXECUTABLE}" PARENT_SCOPE)
> 
> The variable QT_QMAKE_QMAKE_EXECUTABLE is never used however and I
> suspect that it should be QT_QMAKE_EXECUTABLE. If the patch is applied I
> get the following error:
> 
> CMake Error at
> <path_to_cmake>/share/cmake-2.8/Modules/FindQt4.cmake:1356 (message):
> Found unsuitable Qt version "4.7.4" from , this code requires Qt 4.x
> 
> This disappears when the variable is renamed to QT_QMAKE_EXECUTABLE
> 
> -- Is this indeed a typo?
> -- If so, what can I do to get it fixed?

Thanks for testing and catching this so quickly.

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=161a7937

-Brad