[cmake-developers] CheckSymbolExists.cmake

[Brad King]

On 06/05/2013 06:21 PM, Christopher Sean Morrison wrote:
> I actually don't see the function in the current tree.  Maybe someone else already realized how bad it was.. ;)
> Looks like it was maybe replaced with CheckPrototypeDefinition().
> 
> This version from a search looks like what I ran into: http://svn.osgeo.org/geos/trunk/cmake/modules/CheckPrototypeExists.cmake

That version was in KDE.  It was never in CMake:

 $ git rev-list master -- Modules |
   git diff-tree --stdin -r --diff-filter=A --name-only |
   grep -i prototype
 Modules/CheckPrototypeDefinition.c.in
 Modules/CheckPrototypeDefinition.cmake

>> While not ideal, they are not "wrong" names.
> 
> Certainly not wrong, just rather ambiguous and (now recently)
> overlapping in purpose.

The intended purposes were always what they are now.  Only the
implementation was changed to work more closely to the intended
check.  Inevitably some corner cases were going to change but
otherwise the change wouldn't have fixed the bug.

>> Those names are no better IMO. We won't be changing the names.
> 
> You apparently already did.

Not according to the history log shown above.

> If you just don't want to think about how to change them right
> now for the better, so be it. There probably was a more tactful
> way to convey that.

Sorry, I arrived at that wording after incremental editing and
didn't see how it read when finished.

-Brad