[cmake-developers] CMake is slow for project with hundred target and one command with large number of dependencies

[Nicolas Desprès]

On Tue, Jul 23, 2013 at 5:59 PM, Stephen Kelly <steveire at gmail.com> wrote:

> Nicolas Desprès wrote:
>
> > Hi Stephen,
> >
> > Did you have any chance to look at the code? I would love to see it
> > integrated in the next release. That being said, there is no pressure.
> >
>
> I'll have a look now.
>
Thanks!

>
>
>  +    UpdateOutputToSourceMap(outputs, file);
>
> is missing a 'this->', as per the style. There's a couple of repeats of
> that.
>
Done

>
> Please rename
>
>  typedef std::map<std::string, cmSourceFile*> OutputToInputMap;
>
> to OutputToSourceMap for similarity to the OutputToSource variable.
>
Done

>
> I haven't tried it out yet, but it looks sane to me. The
> UpdateOutputToSourceMap could probably be faster if outputs is sorted and
> you use lower-bound insertion in a loop over the map or so. If it's fast
> enough already though, probably no need for that :).
>
Currently, it is fast enough. The path to optimize was search not the
insertion. I have not noticed any performance regression in the insertion.
I liked your idea of inserting in at the end of list/vector and then to
sort it once the configuration is done but I am afraid this require more
knowledge of cmake code base than I have and the patch will be harder to
write.

That's said we can optimize further as I mentioned in my comment (
https://github.com/nicolasdespres/CMake/commit/59c871da8b00554812e93ba9c6e47d864424efb0#L0R2023).
Do you have an opinion about it?


> I'd say the topic can be cleaned up and force pushed for another review.
>
Done.

-Nico
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20130724/b7859e8f/attachment.html>