[cmake-developers] Review request: Qt4 interface includes and defines (Was Re: Interface includes and defines plumbing)

[Clinton Stimpson]

On Monday, January 07, 2013 08:55:40 PM Stephen Kelly wrote:
> Stephen Kelly wrote:
> > Brad King wrote:
> >> On 01/04/2013 12:09 PM, Stephen Kelly wrote:
> >>> Brad King wrote:
> >>>> Yes, please.  Thanks for splitting this out.
> >>> 
> >>> Done, thanks,
> >> 
> >> Thanks for cleaning up the dashboard trouble.  I've merged this
> >> to master!
> > 
> > Great, thanks!
> > 
> > I've pushed two new branches to my gitorious clone.
> 
> I also re-pushed the qt4-target-depends branch to add
> INTERFACE_INCLUDE_DIRECTORIES and INTERFACE_COMPILE_DEFINTIONS to the Qt 4
> targets.
> 
> Alex, Clinton, could you review before I merge to next?
> 

Looks fine to me except that the Qt3Support module needs
-DQT3_SUPPORT

-- 
Clinton Stimpson
Elemental Technologies, Inc
Computational Simulation Software, LLC
www.csimsoft.com