[cmake-developers] linked-usage-cleanup regressed automoc

[Stephen Kelly]

Alexander Neundorf wrote:

> On Wednesday 20 February 2013, Stephen Kelly wrote:
>> Brad King wrote:
>> > Please fix and add this case to the tests.
>> 
>> I've added fix-automoc-linker-language to stage. Alex, could you review
>> please?
> 
> If I see it correctly, actually nothing is done to each target between the
> calls to InitializeMocSourceFile() and the following SetupAutomocTarget().
> So instead of running two loops over the targets, shouldn't it be enough
> to add the source file to the target early on in SetupAutomocTarget(),
> e.g. before the call to AddUtilityCommand() ?

I tried that too, but the problem is that if two different targets are 
dependent, it seems that the link closure is calculated and cached for the 
dependent target before it gets its source file set.

There are a few ways to deal with that, but I went with this one.

I'll merge it soon. Thanks for reviewing.

Steve.