[cmake-developers] Setting ExactCase_FOUND in FPHSA

Stephen Kelly steveire at gmail.com
Fri Feb 15 12:24:46 EST 2013


Hi,

FindPackageHandleStandardArgs sets an uppercase found variable, but not an 
ExactCase_FOUND variable. This is inconsistent with how config files work. 
It also imposes on users the necessity that their FOUND variable is 
uppercase.

This is obviously fixable:

diff --git a/Modules/FindPackageHandleStandardArgs.cmake 
b/Modules/FindPackageHandleStandardArgs.cmake
index e89e9a9..386a9fb 100644
--- a/Modules/FindPackageHandleStandardArgs.cmake
+++ b/Modules/FindPackageHandleStandardArgs.cmake
@@ -298,5 +298,6 @@ function(FIND_PACKAGE_HANDLE_STANDARD_ARGS _NAME 
_FIRST_ARG)
   endif ()
 
   set(${_NAME_UPPER}_FOUND ${${_NAME_UPPER}_FOUND} PARENT_SCOPE)
+  set(${_NAME}_FOUND ${${_NAME_UPPER}_FOUND} PARENT_SCOPE)
 
 endfunction()


find_package(Doxygen)

message("DOXY: ${Doxygen_FOUND}")
message("DOXY: ${DOXYGEN_FOUND}")


Any objections?

Thanks,

Steve.




More information about the cmake-developers mailing list