[cmake-developers] Please review CXXFeatures.cmake

[Rolf Eike Beer]

Am Mittwoch, 14. August 2013, 14:02:35 schrieb Brad King:
> On 08/13/2013 01:54 PM, Rolf Eike Beer wrote:
> > Brad King wrote:
> >> On Win64-vs10-Tv90 it is building with VS 10 but the compiler is VS 9.
> > 
> > I'll switch that over to use CMAKE_CXX_COMPILER_VERSION as suggested
> > below, the error will probably go away then.
> 
> That worked.
> 
> >> For Win32-mingw-gcc-4.5	and Win32-msys-gcc-4.5, does the MinGW port of
> >> the compiler support all the same features?  It is GNU 4.5.0.
> > 
> > I would have expected it so.
> 
> The problem was the if(WIN32) condition for testing /Qstd=c++11
> for the Intel compiler.  It triggered on MinGW and of course that
> GNU compiler doesn't have the flag.  Fixed:
> 
>  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=51ce1aeb

Ah, stupid mistake.

> While at it I added logging of the try_compile output:
> 
>  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cabd6f87
> 
> This should help local investigations of the remaining failures.
> 
> Perhaps you can also teach the test to print out the
> CMakeFiles/CMakeOutput.log and CMakeFiles/CMakeError.log
> content at the end when it got unexpected results.

Will look into it.

> >> For Windows-icl-11.1-*, why do the expected results not just match
> >> for this version?
> > 
> > That is a question I wanted to bring up, too. Can you log into that
> > machine
> > and get me the intermediate results of the try_compile calls?
> 
> It seems to have worked last night anyway.  It also worked for me
> with local testing of the above-linked changes.

Freaky.

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20130814/f3cf435c/attachment.sig>