[cmake-developers] Please review CXXFeatures.cmake

[Brad King]

On 08/02/2013 05:20 PM, Rolf Eike Beer wrote:
> Brad, please don't merge that

Do all of the remaining test failures need the cxx-flags topic to fix?

 http://open.cdash.org/testSummary.php?project=1&name=Module.FindCXXFeatures&date=2013-08-13

I'd like to get these resolved or revert the topic because the noise
on the dashboard is very distracting while trying to get 2.8.12-rc1 out.

On Win64-vs10-Tv90 it is building with VS 10 but the compiler is VS 9.
The logic that sets MSVC_VERSION should be correct in this case so I'm
not sure what is causing the expected results to mismatch.

For Win32-mingw-gcc-4.5	and Win32-msys-gcc-4.5, does the MinGW port of
the compiler support all the same features?  It is GNU 4.5.0.

For the Linux*-LSB4.0 builds with GNU 4.3.2:

 CMake Error at CMakeLists.txt:203 (message):
   C++ feature 'CXXFeatures_cstdint_header_FOUND' was detected, but not
   expected

the LSB-enforcing compilers may provide that header.

For MacOSX10.7-Xcode43-ub, it is the Apple port of the GNU 4.2.1 so
there are more features than expected.

For Windows-icl-11.1-*, why do the expected results not just match
for this version?

Also, IMO "if (CMAKE_COMPILER_IS_GNUCXX)" and "elseif (MSVC)" should
use CMAKE_CXX_COMPILER_ID instead just like the rest of the cases.

Thanks,
-Brad