[cmake-developers] Global flags for creating static libraries

[Brad King]

On 12/17/2012 09:50 AM, Brad King wrote:
> On 12/17/2012 02:01 AM, Evan Pipho wrote:
>> Cleaned up the commits
>>
>> See the new branch here:
>> https://github.com/hiwrac/CMake/commits/static_linker_flags_clean
>>
>> CMAKE_STATIC_LINKER_FLAGS is now optional on all generators. 
>> XCode is supported properly.
> 
> 1. I still see some GetRequiredDefinition used.
> 
> 2. Please format C++ code in less than 80 columns.  Run this
>    check on your topic and ensure it is empty:
> 
>  $ git log origin/master.. --pickaxe-regex -S'.{80}' -- Source
> 
> 3. The addition of /MACHINE:xxx to librarian calls is a change in
>    behavior.  According to the documentation of lib.exe:
> 
>     http://msdn.microsoft.com/en-us/library/h34w59b3.aspx
> 
>    The flag is usually not needed.  In what cases do you need it?
> 
> 4. Please construct a test case that covers these flags.  It is
>    okay if it runs only with MS tools because that is the motivating
>    case anyway.  In Tests/CMakeLists.txt there is a CMAKE_TEST_MSVC
>    condition that adds some MS-specific tests.

There is additional discussion and another proposed implementation here:

 http://www.cmake.org/Bug/view.php?id=10094
 https://github.com/Kitware/CMake/pull/40

-Brad