[cmake-developers] Review request: FindQt4-nonfatal-if-Qt5-found

David Cole david.cole at kitware.com
Tue Oct 23 13:19:30 EDT 2012


On Tue, Oct 23, 2012 at 11:43 AM, Clinton Stimpson <clinton at elemtech.com> wrote:
>
> It looks like that branch removes the error if
> find_package(Qt4 REQUIRED)
> doesn't find Qt 4.x.  No?
>
> If it does remove the error, that seems wrong.  Is there another way to avoid
> the error in the cmake unit tests?
>
> On Friday, October 19, 2012 03:08:26 PM Stephen Kelly wrote:
>> Hi,
>>
>> I've just pushed the FindQt4-nonfatal-if-Qt5-found branch, and before
>> merging it to next, I'd like some review (Alex? Clinton?).
>>
>> Thanks!
>>
>> Steve.
>>
>>
>> --
>>
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Please keep messages on-topic and check the CMake FAQ at:
>> http://www.cmake.org/Wiki/CMake_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
> --
> Clinton Stimpson
> Elemental Technologies, Inc
> Computational Simulation Software, LLC
> www.csimsoft.com
> --
>
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Yeah -- I don't think we should take this branch.

I think we should change callers to look for Qt5 first, and only do
"find_package(Qt4)" if Qt5 is not found first...



More information about the cmake-developers mailing list