[cmake-developers] [CMake 0013600]: fixup_bundle doesn't copy Sparkle.framework

[Mantis Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
http://www.cmake.org/Bug/view.php?id=13600 
====================================================================== 
Reported By:                Tobias Hieta
Assigned To:                
====================================================================== 
Project:                    CMake
Issue ID:                   13600
Category:                   CMake
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2012-10-23 06:56 EDT
Last Modified:              2012-10-23 06:56 EDT
====================================================================== 
Summary:                    fixup_bundle doesn't copy Sparkle.framework
Description: 
After quite a bit of debugging I realized that fixup_bundle has a regexp that
matches Frameworks in order to resolve embedded item. This didn't work properly
for me. Before I made the change the following was given when fixup bundle was
executed (I changed show_status=1 in fixup_bundle to see it)

-- 8/66: copying
'/path/Dependencies/932bede-darwin-i686/Frameworks/Sparkle.framework/Sparkle'
-- key='Sparkle'
--
item='/path/Dependencies/932bede-darwin-i686/Frameworks/Sparkle.framework/Sparkle'
--
resolved_item='/path/Dependencies/932bede-darwin-i686/Frameworks/Sparkle.framework/Sparkle'
-- default_embedded_path='@executable_path/../Frameworks'
--
embedded_item='/path/Dependencies/932bede-darwin-i686/Frameworks/Sparkle.framework/Sparkle'
--
resolved_embedded_item='/path/Dependencies/932bede-darwin-i686/Frameworks/Sparkle.framework/Sparkle'
-- copyflag='1'

This resulted in a warning that resolved_item == resolved_embedded_item and that
it wouldn't be copied.

The error turns out to be the following line in BundleUtilities.cmake

string(REGEX REPLACE "^.*(${item_name}.framework/.*/${item_name}).*$"
"${default_embedded_path}/\\1" embedded_item "${item}")

I changed it to

string(REGEX REPLACE "^.*(${item_name}.framework/${item_name}).*$"
"${default_embedded_path}/\\1" embedded_item "${item}")

to get it to work.

I am not sure if this is just because of the Sparkle framework layout, but
looking at other frameworks it seems quite normal to have Name.framework/Name as
the path to the library.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2012-10-23 06:56 Tobias Hieta   New Issue                                    
======================================================================