[cmake-developers] I: I want to become a maintainer of several modules.

[Brad King]

On 10/05/2012 08:29 AM, Aleksey Avdeev wrote:
> I modified the proposed modules.

Thanks for working on them.  Let's start with FindIcotool since it
is pretty simple and doesn't depend on the other modules.  After
that we can move on to the others.  Please proceed with step 5
of the new maintainer instructions:

 http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer

to get Git access.

>>> 1. FindIcotool
> http://git.altlinux.org/people/solo/public/cmake-modules.git?p=cmake-modules.git;a=blob;f=Modules/FindIcotool.cmake;h=97543113756a72e59175c778eace0dc00220a1e0;hb=ea809d0c5b1cd36b83437043d916fd6eacc1dc5f

Good.  Please tweak the documentation:

(1) Remove the leading/first "#" line that is otherwise empty.
(2) Remove the " (since CMake 2.8.8)" note since the module was
not in CMake 2.8.8.

Also when the module is put in CMake the line

 include(FindPackageHandleStandardArgs)

will need to be

 include(${CMAKE_CURRENT_LIST_DIR}/FindPackageHandleStandardArgs.cmake)

> Done. Value ICOTOOL_VERSION_STRING up over the output:
> 
> icotool --version

The output parsing can be a bit simpler if you use the CMAKE_MATCH_1
variable result from the "if(... MATCHES ...)" command.  It is
mentioned at the bottom of the regex documentation in string():

 http://www.cmake.org/cmake/help/v2.8.9/cmake.html#command:string

Thanks,
-Brad