[cmake-developers] Hacking kwsys processor detection

Rolf Eike Beer eike at sf-mail.de
Tue Nov 20 13:58:47 EST 2012


Brad King wrote:
> On 09/08/2012 12:45 PM, Rolf Eike Beer wrote:
> > I was a bit bored and decided to hack a bit on a bug I filed long ago
> > (http://cmake.org/Bug/view.php?id=10895). I have attached the first 3
> > patches I came up with. I think #1 should just be applied without any
> > further checks ;)
> The copy of KWSys in VTK has had more development on this:
> 
>  http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=595216ab
>  http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=32f08e67
>  http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=72deb33e
> 
> I haven't had time to cherry-pick the changes into CMake and deal
> with all the problems on platforms where CMake builds but VTK does
> not (if any).  Some of the changes conflict with your patches,
> probably because they do some of the same things.

Ok, I guess we now have the new stuff already in CMake. It would be good if 
you could just take the first of that patches as it just fixes some typos. 
I've attached a rebased version of these patches for easier testing.

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-kwsys-fix-typos.patch
Type: text/x-patch
Size: 3162 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20121120/7c2c4fc5/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-kwsys-sum-up-all-caches-found-in-proc-cpuinfo.patch
Type: text/x-patch
Size: 1949 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20121120/7c2c4fc5/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-kwsys-PA-RISC-chips-are-from-HP.patch
Type: text/x-patch
Size: 3628 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20121120/7c2c4fc5/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20121120/7c2c4fc5/attachment.sig>


More information about the cmake-developers mailing list