[cmake-developers] Specifying VS target platform

Brad King brad.king at kitware.com
Mon Nov 19 13:00:08 EST 2012


On 11/19/2012 11:26 AM, Patrick Gansterer wrote:
> I also added an additional commit at factory branch for the 
> GetDocumentation method (which depends on the merged commits).

Good.  That will also be helpful to provide documentation for all
generators no matter what platform generates the documentation.
To do that now we just need to #if-out the implementations of the
generators on platforms where they do not work, except for the
GetDocumentation methods.

> Attached is an unrelated (but required) patch to clean up VS generators 
> before merging. Maybe you can merge this too?

It is logically unrelated but conflicts with the topic after adding
the last commit so I put them together.  They are all working toward
the same goal so in that sense they are related anyway.

I added two commits to fix the build on OS X:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6aa6df56
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=682fbc28

I went back and squashed those in to your first commit.

The build also requires your GetDocumentation change because
"T()" does not work when T is cmGlobalXCodeGenerator since it
has no default constructor.  I merged it and the patch you
attached to 'next' also.

Thanks,
-Brad



More information about the cmake-developers mailing list