[cmake-developers] Correct way to get include directories for a target (automoc regression) ?
Alexander Neundorf
neundorf at kde.org
Sun Nov 11 08:38:39 EST 2012
On Sunday 11 November 2012, Stephen Kelly wrote:
> Alexander Neundorf wrote:
> > In 2.8.9 automoc did not ask the target for its include dirs, but it
> > asked the directory for its include dirs. This contained and still
> > contains as it seems the CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES.
> > In 2.8.10 the target is asked for its include dirs, and it seems there
> > the implicit include dirs have been stripped.
>
> It seems that the bug is in KDE/Phonon. Why do they populate the
> CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES instead of the INCLUDE_DIRECTORIES
> directory property?
>
> The patch that you added looks like a hack to me which is only for the
> benefit of what KDE/Phonon is doing (but maybe shouldn't be). I'd prefer to
> fix KDE/Phonon instead.
It still is a backward compatibility break in cmake, for kdelibs, which is a
big user of cmake.
Does moc know actually know about system include dirs ?
If it doesn't, this is not a hack, but potentially necessary.
Alex
More information about the cmake-developers
mailing list