[cmake-developers] How to fix FindSquish.cmake wrt. backward compatibility ?

David Cole david.cole at kitware.com
Mon Nov 5 12:29:28 EST 2012


I like squish_v3_add_test the best: keeps the conventional prefix, but
still indicates the version it goes with.

On Mon, Nov 5, 2012 at 12:23 PM, Alexander Neundorf <neundorf at kde.org> wrote:
> On Monday 05 November 2012, David Cole wrote:
>> I would prefer squish3_add_test and squish4_add_test, as the version number
>> goes with squish, not with the add_test... Keep the old macros and
>> functions with the same name and same meaning please. We've had too many
>> backwards incompatible complaints in 2.8.10 after only a few days out in
>> the real world.
>
> Ok.
> I added squish_add_test[34]() yesterday.
> I agree squish[34]_add_test() looks nicer, but then the function doesn't have
> the correct prefix anymore, which should be "squish_". Should I do that anyway
> ?
>
> Or squish_v3_add_test(), squish_3_add_test(), squish_add_test_3(),
> squish_add_test_v3() ?
>
> Alex



More information about the cmake-developers mailing list