[cmake-developers] Github pull request for CPack NSIS generator

[Eric Noulard]

2012/5/25 Brad King <brad.king at kitware.com>:
> On 05/25/2012 09:38 AM, Eric Noulard wrote:
>> 2012/5/25 Brad King <brad.king at kitware.com>:
>>>  https://github.com/Kitware/CMake/pull/5
>>
>> I'm not a too good NSIS tester since my usual system is Linux :-)
>>
>> I do cross-test NSIS (cross compile win32 on Linux + NSIS) but
>> I seldom boot Windows...
>>
>> However, I will review (read) the patch.
>
> Thanks.  It conflicts with some of your other changes so I jumped
> to the conclusion that you've worked with the relevant code.
> Perhaps that was only in your documentation sweep though.

Just reviewed the patch.
It's ok and harmless, it is fixing error message and adds documentation.
but you are right it may not be applied as-is because of the
CPack documentation update.

The only missing part was the log error message fix.
I did create a branch (based on current) master which contains
the fix, I did some basic testing but I may be you want
to test it yourself before I merge it?

stage/cpack-nsis-menu-links-adapted

Like I said it does not need in depth testing (besides an actual NSIS
packaging run)
because it "only " change a warning message
(the documentation block part was already up to date on current master)

-- 
Erk
Le gouvernement représentatif n'est pas la démocratie --
http://www.le-message.org