[cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS

[Stephen Kelly]

Peter Collingbourne wrote:

> On Sun, May 13, 2012 at 11:59:20PM +0200, Stephen Kelly wrote:
>> Stephen Kelly wrote:
>> 
>> >>
>> >> Furthermore, there is no need to make paths within the build directory
>> >> absolute.  Each command must be invoked from the home output directory
>> >> (i.e. the build "root" directory), so each command's "directory"
>> >> attribute should be set to that directory, rather than the start
>> >> output directory as in your patch.
>> > 
>> > Fixed now, If I understood you correctly.
>> 
>> I've pushed this to the CMake stage repo now.
>> 
>> Peter, could you verify that I should always use the same directory for
>> the directory JSON property as I do in the patch?
> 
> Yes, this looks fine now.

Great, thanks. I've merged it to next.