[cmake-developers] Do not take CPackNSIS-warnDESTDIRandABSOLUTE yet

Eric Noulard eric.noulard at gmail.com
Thu May 17 04:03:59 EDT 2012


Hi there,

I did merge "CPackNSIS-warnDESTDIRandABSOLUTE" to next may be a little early.
It is functional and do not introduce any regression but
I think I should make some renaming in order to be more consistent.

The variables:
CPACK_WARN_ON_ABSOLUTE_INSTALL_DESTINATION
CPACK_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION
and older one (not coming from this patch)
CPACK_ABSOLUTE_DESTINATION_FILES

are defined in generated cmake_install.cmake files.
So they may be ill-named and should be renamed with a
CMAKE_ prefix because they can be used without CPack.

I'll then make CPack use/monitor  the CMAKE_xxxx renamed variable
and forward definition to/from CPACK_xxx ones.

I'll do that later today and re-push+merge to next today.
In the meantime better not merging current
CPackNSIS-warnDESTDIRandABSOLUTE to master.

-- 
Erk
Le gouvernement représentatif n'est pas la démocratie --
http://www.le-message.org



More information about the cmake-developers mailing list