[cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS

Stephen Kelly steveire at gmail.com
Sun May 13 17:59:20 EDT 2012


Stephen Kelly wrote:

>>
>> Furthermore, there is no need to make paths within the build directory
>> absolute.  Each command must be invoked from the home output directory
>> (i.e. the build "root" directory), so each command's "directory"
>> attribute should be set to that directory, rather than the start
>> output directory as in your patch.
> 
> Fixed now, If I understood you correctly.

I've pushed this to the CMake stage repo now.

Peter, could you verify that I should always use the same directory for the 
directory JSON property as I do in the patch?

Thanks,

Steve.





More information about the cmake-developers mailing list