No subject
Wed May 9 12:08:04 EDT 2012
.org/stage/cmake</a><br>
</blockquote>
=A0 =A0 f00f58f..2e48952 =A0master =A0 =A0 -> stage/master<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/<u></u>AutomocUs=
eTargetProperties<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/<u></u>Determine=
VsServicePack2012<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/ImproveFindSDLxx=
xModules<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/UpdateEmacsMode-=
<u></u>bug0013548<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/clang-PIE<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/file-DOWNLOAD-EX=
PECTED_<u></u>HASH<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/generator-expres=
sion-<u></u>refactor<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/osx-sysroot-clea=
nup<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/qt5-qtdialog-por=
t<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/use-generator-ta=
rget<br>
=A0 x [deleted] =A0 =A0 =A0 =A0 (none) =A0 =A0 -> stage/vs8-generator-do=
c<br>
<br>
We're not quite ready for 2.8.10-rc1 yet, though, because of some chang=
es<br>
made today that we'd like to have in...<br>
<br>
<br>
Steve, we didn't take "generator-expression-target-<u></u>properti=
es" yet because<br>
the logic is incorrect in this commit:<br>
<a href=3D"http://cmake.org/gitweb?p=3Dcmake.git;a=3Dcommitdiff;h=3D4557c8d=
b" target=3D"_blank">http://cmake.org/gitweb?p=3D<u></u>cmake.git;a=3Dcommi=
tdiff;h=3D<u></u>4557c8db</a><br>
<br>
The test should be !IsGeneratorExpression, not 0!=3D'$' && =
1!=3D'<' -- please<br>
write a function there instead to make the logic more readable. And<br>
consider adding a test of the case so that this would have been a test<br>
failure for you rather than having Brad and I catch it during review.<br>
<br>
Also, you've added $<BOOL, $<STREQUAL, $<ANGLE-R and $<COMM=
A, but did not<br>
add any tests of these expressions. We should really have tests of those<br=
>
before we take this change into 'master'.<br>
<br>
Do you want us to hold "-rc1" for another day or two while you ad=
dress<br>
these?<br>
<br>
</blockquote>
<br></div></div>
I would like to get one small fix into rc1, where I'm sure it fixes a b=
ug:<br>
<br>
stage/ninja-OBJECT_DEPENDS<br>
<a href=3D"http://cmake.org/gitweb?p=3Dstage/cmake.git;a=3Dcommitdiff;h=3D8=
f0e08d503c83f47f13efc21437e30b96c114639" target=3D"_blank">http://cmake.org=
/gitweb?p=3D<u></u>stage/cmake.git;a=3Dcommitdiff;<u></u>h=3D<u></u>8f0e08d=
503c83f47f13efc21437e30<u></u>b96c114639</a><br>
<br>
Currently OBJECT_DEPENDS are only "order-only dependencies" which=
means<br>
"changes in order-only dependencies alone do not cause the output to b=
e rebuilt"<br>
but a rebuild should happen when OBJECT_DEPENDS is set.<br>
<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
<br>
Thanks,<br>
David<br>
<br>
<br>
<br>
--<br>
<br>
Powered by <a href=3D"http://www.kitware.com" target=3D"_blank">www.kitware=
.com</a><br>
<br>
Visit other Kitware open-source projects at <a href=3D"http://www.kitware.c=
om/opensource/opensource.html" target=3D"_blank">http://www.kitware.com/<u>=
</u>opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href=3D"http:/=
/www.cmake.org/Wiki/CMake_FAQ" target=3D"_blank">http://www.cmake.org/Wiki/=
<u></u>CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href=3D"http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-develop=
ers" target=3D"_blank">http://public.kitware.com/cgi-<u></u>bin/mailman/lis=
tinfo/cmake-<u></u>developers</a><br>
<br>
</blockquote>
--<br>
<br>
Powered by <a href=3D"http://www.kitware.com" target=3D"_blank">www.kitware=
.com</a><br>
<br>
Visit other Kitware open-source projects at <a href=3D"http://www.kitware.c=
om/opensource/opensource.html" target=3D"_blank">http://www.kitware.com/<u>=
</u>opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href=3D"http:/=
/www.cmake.org/Wiki/CMake_FAQ" target=3D"_blank">http://www.cmake.org/Wiki/=
<u></u>CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href=3D"http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-develop=
ers" target=3D"_blank">http://public.kitware.com/cgi-<u></u>bin/mailman/lis=
tinfo/cmake-<u></u>developers</a><br>
</blockquote></div><br>
--f46d04462dd2d5c78f04ca8cda0e--
More information about the cmake-developers
mailing list