[cmake-developers] [CMake] CMake 2.8.9-rc1 ready for testing!

[Claus Klein]

Hi Dave,

I found one more Ninja issue;

The Ninja Eclipse Generator crashes while make target generation. No  
Idea why, but this helps for now:

diff --git a/Source/cmExtraEclipseCDT4Generator.cxx b/Source/ 
cmExtraEclipseCDT4Generator.cxx
index ab11307..b9e360b 100644
--- a/Source/cmExtraEclipseCDT4Generator.cxx
+++ b/Source/cmExtraEclipseCDT4Generator.cxx
@@ -964,6 +964,11 @@ void  
cmExtraEclipseCDT4Generator::CreateCProjectFile() const
         it != this->GlobalGenerator->GetLocalGenerators().end();
         ++it)
      {
+    if (std::string("Ninja") == generator->GetName())
+      {
+      break;    // FIXME with Ninja it crashes! For now not relay  
needed! ck
+      }
+
      const cmTargets& targets = (*it)->GetMakefile()->GetTargets();
      cmMakefile* makefile=(*it)->GetMakefile();
      std::string subdir = (*it)->Convert(makefile- 
 >GetCurrentOutputDirectory(),
claus-kleins-macbook-pro:cmake clausklein$



//Regards
Claus





On 26.06.2012, at 16:39, David Cole wrote:

> Thanks.
>
> I've pushed a fix and merged it to 'next' -- we'll get it into rc2.
>
>  http://cmake.org/gitweb?p=3Dcmake.git;a=3Dcommitdiff;h=3Db163c45445ce75eb=
> 68d0835b24d4c90ad5b9f6f7
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120626/9b890e29/attachment.html>