[cmake-developers] [CMake 0013314]: Fixes for various dashboard test failures

[Mantis Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
http://public.kitware.com/Bug/view.php?id=13314 
====================================================================== 
Reported By:                Daniel R. Gomez
Assigned To:                
====================================================================== 
Project:                    CMake
Issue ID:                   13314
Category:                   CMake
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2012-06-18 16:02 EDT
Last Modified:              2012-06-18 16:02 EDT
====================================================================== 
Summary:                    Fixes for various dashboard test failures
Description: 
This omnibus bug report addresses a handful of test failures that appear to have
a straightforward solution. (Note: I have not been able to test these changes,
as the normal CTest dashboard build reverts the Git repository it works from; is
there a way to do this?)

A patch against git master is attached.


Failed test: Assembler

    http://open.cdash.org/testDetails.php?test=149633033&build=2372627
    http://open.cdash.org/testDetails.php?test=149289472&build=2361814

Test fails because a .s assembly file is compiled without CFLAGS, and then
linked with CFLAGS. The CFLAGS for this dashboard build select 64-bit output,
but the compiler/linker do 32-bit by default. The linker barfs when told to link
a 32-bit object against a 64-bit C library.

Solution: Set COMPILE_FLAGS on the assembly source to ${CMAKE_C_FLAGS}. This
should be safe because the test is written so that the assembly is only ever
compiled by the C compiler.


Failed test:  FindPackageModeMakefileTest

    http://open.cdash.org/testDetails.php?test=148879982&build=2372627

Similar to the above, an object file is compiled with CXXFLAGS, and then linked
without CXXFLAGS, and the linker barfs on the mismatched ABIs.

Solution: Use CXXFLAGS in the makefile's link rule. This is trivial enough, so I
also retooled the makefile not to require GNU Make. (Using backticks instead of
$(shell ...) is safe so long as you guard against the possibility of backslashes
getting inside the backticks, which is why I used temporary shell variables.)


Failed test: IncludeDirectories

    http://open.cdash.org/testDetails.php?test=148879964&build=2372627

Test fails because the HP-UX compiler really really wants source files to end
with a newline.

Test solution: Pretty indentation and FILE(WRITE ...) don't mix.


Bonus warning fix for test: VSGNUFortran

    http://open.cdash.org/testDetails.php?test=149538620&build=2361814

"warning: tokens ignored at end of directive line"

(Note: The test failure is due to the build host's software environment; I'm
working on that)
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2012-06-18 16:02 Daniel R. GomezNew Issue                                    
2012-06-18 16:02 Daniel R. GomezFile Added: cmake-test-fixes.patch              
     
======================================================================