[cmake-developers] KWStyle line length test failure

David Cole david.cole at kitware.com
Tue Jun 12 19:04:50 EDT 2012


On Mon, Jun 11, 2012 at 6:53 PM, Peter Kümmel <syntheticpp at gmx.net> wrote:

> On 11.06.2012 18:02, David Cole wrote:
>
>> In 'next' we are seeing dashboard test failures (and I am seeing it on my
>> local build too, of course) that are related
>> to recent edits in Source/cmNinjaTargetGenerator.**cxx.
>>
>>   193: Processing /Users/davidcole/Dashboards/My Tests/CMake/Source/**
>> cmNinjaTargetGenerator.cxx
>>   193: Error #0 (341) Line length exceed 80 (max=79)
>>   193: Error #0 (382) Line length exceed 100 (max=79)
>>
>> Please fix them in time for the dashboard run tonight if it's at all
>> possible.
>>
>> Brad and I would like to do our final merge session before 2.8.9-rc1
>> tomorrow.
>>
>>
> OK, I fix it. Maybe more than 'allowed'.
>
> Peter
> --
>
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/**
> opensource/opensource.html<http://www.kitware.com/opensource/opensource.html>
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/**CMake_FAQ<http://www.cmake.org/Wiki/CMake_FAQ>
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/cgi-**bin/mailman/listinfo/cmake-**developers<http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers>
>


Thank you for fixing your source files to conform to our 79 character line
length limit.

But ... this commit is not cool:


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7b91c3dfac88b2d01a8bac71e800032fcd03ec54

And your reply here leads me to believe that you suspected that we wouldn't
think it's cool... Doubly not cool.

If we want to increase the line length limitation, then we should discuss
it and come to a reasonable consensus.

We have reasons for wanting to keep the line length short, and we realize
it's not always comfortable. But it really helps out viewing diffs in
side-by-side diff viewers, (as one example). I'm sure there are other
examples, too, and I'll let others chime in if they'd like to, but we will
be putting this value back down to 79. We're not going to increase it
unless it's discussed first, and everybody agrees that it would be better
with a higher value.


Thanks for listening,
David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120612/b7a20632/attachment.html>


More information about the cmake-developers mailing list