[cmake-developers] -GNinja on Windows

[Peter Kümmel]

On 12.06.2012 15:37, Bill Hoffman wrote:
> On 6/12/2012 5:27 AM, Peter Kümmel wrote:
>>> Yes sounds strange, but atm I've no better idea, ninja adds the quotes
>>> because it internally has a space separated list, see the link in my
>>> comment in merge request:
>>>
>>> https://github.com/martine/ninja/pull/324
>>
>> This is the reason for the patch:
>> http://open.cdash.org/testDetails.php?test=149373149&build=2355021
>>
>> Peter
> As I suspected the pull request is getting some questions.  It seems
> like it is in the wrong place.   Seems like the code that reads the
> string should be stripping it.

When you debug it, you will see that it is not that simple.
When the path is read you don't know what is done with it later on.

And feeding fopen with " is wrong anyway.

>
> When ninja read the string: "C:\Dashboards\My
> Tests\CMake-ninja-build\Tests\OutOfBinary\CMakeFiles\outlib.dir\outlib.c.obj",
> it should have removed the start and end quotes if it found them.
>
>
> "C:\Dashboards\My
> Tests\CMake-ninja-build\Tests\OutOfBinary\CMakeFiles\outlib.dir\outlib.c.obj".d
>
>
>
> -Bill
> --
>