[cmake-developers] Patch to support SVN externals in CTest update

Brad King brad.king at kitware.com
Mon Jul 30 09:56:57 EDT 2012


On 07/30/2012 09:45 AM, Xavier Besseron wrote:
> I am affected by the issue in bug 12630
> (http://public.kitware.com/Bug/view.php?id=12630), so I prepared a
> patch.

Thanks for working on this!

> This patch adds support for svn externals during CTest update. I
> tested it successfully  with svn 1.6/1.7, Linux/Windows and with
> nested externals as well.
> 
> Summary of the modifications:
>     - Add SVNInfo structure to hold info about each repository
>     - Get the list of external repositories (using 'svn status' and
> ExternalParser)
>     - Run 'svn info' for all repositories, before and after the update
>     - Run 'svn log' for all repositories
>     - Build the correct path for all updated files (ie add the
> external prefix and remove the svn base)
> 
> Let me know if you have any questions or comments.

The changes will be much easier to review in smaller pieces.
Please split this patch into a series.  For example, the first
patch should add the SVNInfo infrastructure with no functional
changes.  Each step in the series should still compile and
pass the UpdateSVN test.

Separately, please also extend the UpdateSVN test to exercise
the new functionality.

Thanks,
-Brad



More information about the cmake-developers mailing list