[cmake-developers] [CMake 0013426]: FindSWIG.cmake doesn't mark variables as advanced

Mantis Bug Tracker mantis at public.kitware.com
Thu Jul 19 14:15:09 EDT 2012


The following issue has been SUBMITTED. 
====================================================================== 
http://www.cmake.org/Bug/view.php?id=13426 
====================================================================== 
Reported By:                Matt Williams
Assigned To:                
====================================================================== 
Project:                    CMake
Issue ID:                   13426
Category:                   Modules
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2012-07-19 14:15 EDT
Last Modified:              2012-07-19 14:15 EDT
====================================================================== 
Summary:                    FindSWIG.cmake doesn't mark variables as advanced
Description: 
FindSWIG.cmake sets number of variables in the process of finding SWIG, notably:
• SWIG_DIR
• SWIG_EXECUTABLE
• SWIG_VERSION

Of the three of these, SWIG_EXECUTABLE is used to obtain the other two and it's
CMake convention to only have one non-advanced variable per module which can
then set the others. In this case, SWIG_DIR and SWIG_VERSION could be
mark_as_advanced() without any loss to functionality while making the cmake-gui
display cleaner.

Searching around, I see at least two projects which are manually setting these
varaibles as advanced in their own code (presumably simply to make cmake-gui or
ccmake cleaner):

http://dtk.inria.fr/+sup/dtk/dtk-clone-sup/blobs/ac62dd518871e2ccbeebe5c96dc6c6b1c815539f/cmake/dtkDependencies.cmake
http://speect.git.sourceforge.net/git/gitweb.cgi?p=speect/speect;a=commitdiff_plain;h=36485b8b7fc38be46c11aeedbc3ccf4abd26f2f6
http://www.mail-archive.com/cmake@cmake.org/msg38240.html

Steps to Reproduce: 
Run a CMake script which calls find_package(SWIG) and then run 'cmake -LA' and
see that all three variables are shown. Only SWIG_EXECUTABLE should be.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2012-07-19 14:15 Matt Williams  New Issue                                    
======================================================================




More information about the cmake-developers mailing list