[cmake-developers] [PATCH] Added very basic Windows CE Makefile support

Rolf Eike Beer eike at sf-mail.de
Sat Jul 14 16:18:08 EDT 2012


Patrick Gansterer wrote:
> Hi,
> 
> On Sat, 14 Jul 2012 21:08:24 +0200, Rolf Eike Beer wrote:
> > -in Modules/Platform/Windows-cl.cmake you initialize some variables
> > in both
> > branches of an if(). You should keep the order you set them the same
> > in both
> > branches as is makes comparing this much easier.
> 
> Where exactly? I don't find it. :-/

Directly before that:

> > -you don't set CMAKE_DEBUG_PLATFORM_DEFINES for WinCE. I don't know
> > if that is
> > a bug or intentional. If it is a bug then set it, otherwise I would
> > add a
> > comment why this isn't needed.
> 
> The WinCE compier has no support for /RTC1.

But you don't add any of the other things you set for release configuration 
either, that's what wonders me.

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120714/7bbc214b/attachment.sig>


More information about the cmake-developers mailing list