[cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Rolf Eike Beer]

Patrick Gansterer wrote:
> Hi,
> 
> at first: Sorry for the very long delay.

I do not really care for this, but just some minor stylistic nitpicks:

-in Modules/Platform/Windows-cl.cmake you initialize some variables in both 
branches of an if(). You should keep the order you set them the same in both 
branches as is makes comparing this much easier.

-you don't set CMAKE_DEBUG_PLATFORM_DEFINES for WinCE. I don't know if that is 
a bug or intentional. If it is a bug then set it, otherwise I would add a 
comment why this isn't needed.

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120714/b63a828e/attachment.sig>