[cmake-developers] Improving CPack Documentation (and may be others as well)

[Rolf Eike Beer]

Eric Noulard wrote:
> 2012/1/31 Eric Noulard <eric.noulard at gmail.com>:
> > 2012/1/31 Rolf Eike Beer <eike at sf-mail.de>:
> >>> Ok Agreed.
> >>> Just merged the branch to next.
> >> 
> >> Just spotted a bug in it:
> >> 
> >> @@ -559,6 +511,8 @@ bool cmDocumentation::CreateSingleModule(const char*
> >> fname,
> >>     {
> >>     if(line.size() && line[0] == '#')
> >>       {
> >> +      /* line beginnings with ## are mark-up ignore them */
> >> +      if (line[1] == '#') continue;
> >>       // blank line
> >>       if(line.size() <= 2)
> >> 
> >> Just assume line is "#", then you will access beyond end of line.
> > 
> > Nice catch I'll fix it later tonight.
> 
> Should be fixed and pushed.
> 
> Merge topic 'ImproveCPackDoc-reloaded' into next
> 
> cc4ac32 Calm down compiler warning about unused var
> 1b31c19 Fix potential bad memory access, thanks to Rolf
                                                     ^^^^

You should go and fix this or I will be angry with you for ages. ;)

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120131/a9759500/attachment.sig>