[cmake-developers] valgrind errors

[Rolf Eike Beer]

Bill Hoffman wrote:
> We seems to have some valgrind errors on the dashboard:
> 
> http://www.cdash.org/CDash/viewDynamicAnalysisFile.php?id=2554459
> 
> Seems to have started with this day:
> http://www.cdash.org/CDash/viewChanges.php?project=CMake&date=2011-11-12
> 
> http://www.cdash.org/CDash/viewUpdate.php?buildid=1717708
> 
> I think it might be this find module change that has exposed the issue:
> 
> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f30f9a500c5e5aeb053c41307
> dab9987735570dd
> 
> Looks like the status is somehow not getting set for a call to message.

While the reason for this occurrence has been long fixed, I just pushed the 
topic "uninitialized-var-in-if" into next that fixed the underlying problem.

This introduced a new directory Tests/Syntax and a first tests there. It does

  if (NOT foo bar STREQUAL "foo bar")

and triggers this error, which now does not use an unitinialized variable 
anymore. Since it's a clear syntax error I set it to be a FATAL_ERROR. I think 
we should put more such tests in there, would easily allow us to increase 
coverage as e.g. in cmIfCommand many error branches are currently not part of 
the coverage.

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120120/3bfa8b72/attachment.sig>